Repository navigation
Conversation
|
@sandros94 is attempting to deploy a commit to the unjs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The celld page was written against celld 0.2.0, and since then celld had a few releases with breaking changes (latest is 0.5.0). I re-ran the whole setup against 0.5.0 and updated the page to match what actually happens on the wire now.
What changed on the page
celld diagnoseno longer "only checks access": bothdiagnoseand every node at startup now send four conditional writes and a ranged read underprobe/, andmountx/s3passes them. The old known problem is gone, and ranged reads are listed as the fourth bucket requirementfencing.mdlink was dead, celld moved that content toguarantees.mdDeleteObjects, multipart uploads (LTX segments ≥ 5 MiB and large R2 writes) anddelimiter/max-keys/continuation-tokenon listsSIGTERMhandoff, crash recovery, Workers KV, the R2 binding requests andcelld cell listhttpMetadata,customMetadata,checksums), since the gateway only storesx-amz-meta-mtimePUTsection stays, but notes that 0.5.0 did not show the failure (two nodes, 200 raced cells, zero failed requests) while the gateway behavior is unchanged. So to me this is still a ticking bombtest/integrations/celld.test.tsonly gets comment updates, as the related issue has more to it other than celld integration itself. The assertions are untouched and still pass on 0.5.0.How it was tested
celld0.5.0 release binary +esbuild, one host, one gateway process,node-fsdriver over an ext4 directorypnpm lint,pnpm typecheckand the celld suite (3/3)The R2 metadata limitation will get its own issue, as I'd rather discuss the approach there first, but first I'll comment some more on #20 with new findings and hopefully a followup proposal