Repository navigation
fix(antigravity): bound silent post-settle background command holds #40858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juliusmarminge
merged 7 commits into
pingdotgg:main
from
Lokkuchakreshkumar:fix/39820-bound-silent-background-hold
Nov 22, 2026
+187
−2
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4994f6c
fix(antigravity): bound silent post-settle background command holds
878655e
Merge origin/main into fix/39820-bound-silent-background-hold
juliusmarminge 3cb62c3
refactor(acp): describe the post-settle hold bound as it behaves
juliusmarminge 29ff9c5
fix(acp): arm the post-settle hold bound when a prompt settles awaiti…
juliusmarminge c89375f
fix(acp): bound a held turn by session silence, not time since settle…
juliusmarminge f193ef6
fix(acp): only expire a held turn when a silent command is its last hold
juliusmarminge 79fff87
Merge origin/main into fix/39820-bound-silent-background-hold
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wake the post-settle watcher when its turn completes.
After settlement, the watcher sleeps until the quiet deadline. Normal finalization neither interrupts nor wakes it. The forked fiber is discarded at
Effect.forkIn(sessionScope), and no handle is stored. A command that finishes soon after settlement therefore leaves the watcher asleep for up to the full timeout. The watcher closure keeps that turn's context, including its text and tool data, reachable until then. Across repeated turns, each one can hold a completed context for up to the timeout.Race only the sleep against
context.completed. Do not race the whole watcher. If finalization signalscontext.completedfrom inside the watcher, that race can interrupt the remaining finalization work. Make sure the loop exits oncecontext.finalizedis set, so a resolved race cannot cause repeated immediate wakeups. Keep the expiry unchanged while the turn is open.