Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Once an ACP Registry agent (such as Devin) is installed and its index is cached at
~/.t3/caches/acp-registry/registry.json, T3 Code never refreshes that cached index during normal operation or when clicking Refresh in provider settings:AcpRegistryCatalog.loadRegistry()readsregistryReforregistry.jsonfrom disk without checking freshness or refreshing it.inspect()andresolve()callloadRegistry(). Because an already-installed agent has its previous binary/package version on disk,installBinary()/ensureGlobalPackage()return the old version immediately—so fix(acp-registry): reinstall the current version when a cached build was removed upstream #40261'sdownload_failedfallback never runs.AcpRegistryDriver.invalidateCachescleared probe and live session caches but did not refresh the ACP Registry index.As a result, installed ACP Registry agents stayed pinned to their initial version across restarts and Settings refreshes until the user removed and re-added the provider (calling
prepare()) or opened the Add Provider → ACP Registry search dialog (search()).Change
refreshIndex(options?: { readonly maxAgeMs?: number })toAcpRegistryCatalog(packages/provider-acp-registry/src/server/AcpRegistrySupport.ts), reusingrefreshRegistry()andrecentRegistry(maxAgeMs)so concurrent refreshes deduplicate viaregistrySemaphoreand offline failures fall back cleanly to the cachedregistry.json.AcpRegistryDriver(packages/provider-acp-registry/src/server/driver.ts):enrichProviderCachedcallscatalog.refreshIndex({ maxAgeMs: PROBE_SUCCESS_TTL_MS })before a fresh probe for enabled registry instances (keeping coldinspect()on disk with zero startup network wait, while allowing boot enrichment and post-TTL periodic refreshes to pick up new releases).invalidateCachescallscatalog.refreshIndex()for enabled registry instances so Settings → Refresh immediately fetches the latest registry index and installs the updated agent version on the refresh probe.Scope and approval
Small, focused bug fix for an obvious defect under
CONTRIBUTING.md: installed ACP Registry agents never see upstream releases without removing and re-adding the provider. OnlyAcpRegistryCatalogindex refresh,AcpRegistryDrivercache/enrichment hooks, and focused unit/driver tests are changed.Verification
Failing test first
Added
refreshes a cached registry index on enrichment and explicit cache invalidationinpackages/provider-acp-registry/src/server/driver.test.ts, seeding a disk-cached1.0.0registry.jsonand installed1.0.0binary while the registry serves2.0.0then3.0.0.On
origin/main(3b3f8808f4):With the fix, both
driver.test.ts(enrichment upgrade1.0.0→2.0.0, explicitinvalidateCachesupgrade2.0.0→3.0.0, disabled instance makes 0 registry requests) and the newTestClockcase inAcpRegistrySupport.test.ts(cold disk inspect = 0 requests,maxAgeMsreuse/expiry, forced refresh, offline fallback + retry) pass.Runtime transcript against the live ACP Registry CDN and real Devin CLI
Ran an isolated temp-dir script against
AcpRegistrySupport.makeAcpRegistryCatalog+AcpRegistryDriveron Linux aarch64, seeded with a stale3000.12.57registry.jsonand an already-installedtools/devin/3000.12.57/linux-aarch64/bin/devin:Cold
inspect()returned immediately from the stale disk cache; background enrichment then fetched the live ACP Registry index (3000.14.30821), downloaded and extracted the3000.14.30821Devin binary, probeddevin acp, and updated the provider snapshot.Checks
vp run check:changed origin/main:format,lint,knip 1/2,knip 2/2,graphql (apps/server): passtypecheck(10 affected packages): passtest(5 files, 94 tests): passNot checked: Windows/macOS native host execution (the binary catalog unit tests run under simulated
linux-x64host services as in existingAcpRegistrySupport.test.tstests).Implemented and verified by Gemini 4 Neon via the Antigravity harness in T3 Code.