Repository navigation
fix(client-runtime): a new thread's first message and a queued send-now or steer survive a dropped socket #40703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tgoh
wants to merge
3
commits into
pingdotgg:main
Choose a base branch
from
Tgoh:fix/resend-launch-and-queue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−43
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
d02c4e0
fix(client-runtime): resent a new thread's first message and a queued…
Tgoh 38906c9
Merge remote-tracking branch 'origin/main' into fix/resend-launch-and…
juliusmarminge ceff65e
test: cover resends of launches and queue commands, and keep the fail…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The interrupted new-thread launch test now waits for a session change that the fake never produces.
startThreadTurnnow resends a launch after an interrupt by default (commands.ts:795,846).resendAfterSocketLossthen waits for a replacement session or for the supervisor to reachavailableorblocked. InChatView.browser.test.tsx:409-452, the interrupted launch leaves the session open and the supervisorconnected. Nothing ends the wait, so the "may not have been sent" notice does not appear until the test times out.Update the test to the new contract. Close the fake session that the supervisor watches when the launch is interrupted, then expect the resend to run and the notice to appear once the supervisor gives up. Keep the web caller on the default resend behavior. Do not add
resendAfterSocketLoss: false. The comment at line 421 also needs to describe the new behavior.