Repository navigation
perf(server): new worktrees reuse the source checkout's submodule objects #40697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliusmarminge
wants to merge
1
commit into
main
Choose a base branch
from
factory/issue-9853-a23269
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the selected submodule commit after
--dissociate.When the selected gitlink commit exists only in the source submodule store, the borrowed clone can read it through the alternate.
--dissociatethen runsgit repack -a -dand removes the alternate before the submodule checkout. The repack keeps only objects reachable from the cloned refs, so the selected commit is dropped. The submodule checkout then fails withupload-pack: not our ref. The plain fallback fails with the same error, because the remote does not advertise that commit. The new worktree keeps the submodule at the previous commit with an unchecked-out gitlink, even though the source checkout holds the selected commit.The required behavior is that a worktree created from a source that holds the selected gitlink commit contains that commit and its checked-out files. The commit must remain available after dissociation. The inspected code does not establish how to preserve the commit across dissociation, so this comment does not prescribe a specific change.