Repository navigation
fix(provider-acp-registry): recognize antigravity binary name for post-settle continuation - #39821
charlesbine wants to merge 1 commit into
Conversation
…t-settle continuation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Thanks for this. T3 Code has its own driver for Antigravity, and that is the supported way to use it: changes that make the same agent work through the ACP Registry are not taken. T3 Code already supports Antigravity through its own driver, including background-command continuation added in #38864. This change extends an Antigravity-specific exception in the generic ACP Registry path, which falls under the policy to support this agent through its dedicated driver. The binary-name mismatch you identified explains the reported behavior. Please use the Antigravity provider; if the same failure occurs there, that would be a supported-driver bug we can investigate. Closing. |
Problem
In #38864,
isAntigravityCliinpackages/provider-acp-registry/src/server/adapter.tsonly matches/^agy(\.exe|\.cmd)?$/iagainstcommandPath.However, the binary inside Google's Antigravity CLI archive—and inside T3 Code's own managed install directory (
~/.t3/tools/antigravity-cli/<version>/antigravity)—is namedantigravity(orantigravity.exeon Windows), whileagyis the Homebrew/installer wrapper name. A local ACP Registry provider configured withcommandPath: ".../antigravity"missesisAntigravityCli, soenablePostSettleContinuation,deferFinalizeForBackgroundWork,wakeOnDetachedRequest, andreplyEndsWithUsageUpdatestay off. When a background command finishes and wakes the agent, T3 drops the late output and fails latesession/request_permissionrequests with JSON-RPC-32603(ACP request handler failed for method 'session/request_permission').Change
isAntigravityCliinpackages/provider-acp-registry/src/server/adapter.tsfrom/^agy(\.exe|\.cmd)?$/ito/^(?:agy|antigravity)(\.exe|\.cmd)?$/i(matching the existingisDroid,isGlm, andisVibebinary-name checks in the same function).continues late output only for agytable inapps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.tswith.../antigravityandantigravity.exe.Scope
Small fix (6 lines) for an obvious gap in #38864; no separate issue needed per
CONTRIBUTING.md.Verification
v0.1.10and verified inv0.1.11with a localacpRegistryprovider pointing at~/.t3/tools/antigravity-cli/1.5.12/antigravity(commandArgs: ["acp"]): backgroundedrun_command/invoke_subagentwakeups were silently dropped and latesession/request_permissioncalls failed with-32603(permissions.go:84), whereas symlinking the same binary toagyactivated the fix(server): Antigravity threads keep going after a background command finishes #38864 continuation path..../antigravityandC:\tools\antigravity.exerows onmain(ccc1feb15572) and ranvp test run apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts -t "continues late output only for agy": both new rows failed withAssertionError: late output must only wake agy: expected [] to have a length of 1 but got +0.5 passed), andvp run check:changedpassed across format, lint (0 warnings/0 errors), knip, graphql, typecheck (10 packages), and tests (58/58 passed acrossAcpRegistryAdapterV2.test.tsandAgentContextBudget.test.ts).Created with Gemini 4 Neon in T3 Code.