Skip to content

fix(provider-acp-registry): recognize antigravity binary name for post-settle continuation - #39821

Closed
charlesbine wants to merge 1 commit into
pingdotgg:mainfrom
charlesbine:fix/acp-registry-antigravity-binary-name
Closed

charlesbine wants to merge 1 commit into
pingdotgg:mainfrom
charlesbine:fix/acp-registry-antigravity-binary-name

Conversation

@charlesbine

@charlesbine charlesbine commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem

In #38864, isAntigravityCli in packages/provider-acp-registry/src/server/adapter.ts only matches /^agy(\.exe|\.cmd)?$/i against commandPath.

However, the binary inside Google's Antigravity CLI archive—and inside T3 Code's own managed install directory (~/.t3/tools/antigravity-cli/<version>/antigravity)—is named antigravity (or antigravity.exe on Windows), while agy is the Homebrew/installer wrapper name. A local ACP Registry provider configured with commandPath: ".../antigravity" misses isAntigravityCli, so enablePostSettleContinuation, deferFinalizeForBackgroundWork, wakeOnDetachedRequest, and replyEndsWithUsageUpdate stay off. When a background command finishes and wakes the agent, T3 drops the late output and fails late session/request_permission requests with JSON-RPC -32603 (ACP request handler failed for method 'session/request_permission').

Change

  • Broaden isAntigravityCli in packages/provider-acp-registry/src/server/adapter.ts from /^agy(\.exe|\.cmd)?$/i to /^(?:agy|antigravity)(\.exe|\.cmd)?$/i (matching the existing isDroid, isGlm, and isVibe binary-name checks in the same function).
  • Extend the existing continues late output only for agy table in apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts with .../antigravity and antigravity.exe.

Scope

Small fix (6 lines) for an obvious gap in #38864; no separate issue needed per CONTRIBUTING.md.

Verification

  • Found live on T3 Code v0.1.10 and verified in v0.1.11 with a local acpRegistry provider pointing at ~/.t3/tools/antigravity-cli/1.5.12/antigravity (commandArgs: ["acp"]): backgrounded run_command / invoke_subagent wakeups were silently dropped and late session/request_permission calls failed with -32603 (permissions.go:84), whereas symlinking the same binary to agy activated the fix(server): Antigravity threads keep going after a background command finishes #38864 continuation path.
  • Failing test first: Added the .../antigravity and C:\tools\antigravity.exe rows on main (ccc1feb15572) and ran vp test run apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts -t "continues late output only for agy": both new rows failed with AssertionError: late output must only wake agy: expected [] to have a length of 1 but got +0.
  • After fix: All 5 rows in the table passed (5 passed), and vp run check:changed passed across format, lint (0 warnings/0 errors), knip, graphql, typecheck (10 packages), and tests (58/58 passed across AcpRegistryAdapterV2.test.ts and AgentContextBudget.test.ts).

Created with Gemini 4 Neon in T3 Code.

@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The adapter now recognizes local ACP registry commands named agy or antigravity, with optional .exe or .cmd extensions and case-insensitive matching. Tests add macOS and Windows Antigravity paths for late-output continuation.

Changes: Antigravity command detection

Layer / File(s) Summary
Command detection and continuation
packages/provider-acp-registry/src/server/adapter.ts, apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts
The adapter detects agy and antigravity command variants for Antigravity-specific behavior. The related comment names both commands. Tests add macOS and Windows Antigravity paths, each expecting one continuation offer.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#37485: Enables buffered post-settle continuation for local agy commands. This change extends the command detection used by that continuation behavior.

Suggested labels: bugfix

Suggested reviewers: t3dotgg, macroscopeapp

Merge Risk: Minimal · up to c8eb6

Local ACP Registry providers configured with the Antigravity binary path will now get the same post-settle continuation behavior as the installer wrapper name. The change is small and covered by new test cases, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the actual change: the Antigravity CLI detection in provider-acp-registry now accepts the antigravity binary name, which enables post-settle continuation. It follows the conventional…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description covers all four template sections. Problem explains the bug in #38864 where isAntigravityCli only matches agy, with reproduction context (ACP registry provider, JSON-RPC -32603 failure…
Full details: Title check

Explanation

The title names the actual change: the Antigravity CLI detection in provider-acp-registry now accepts the antigravity binary name, which enables post-settle continuation. It follows the conventional commit format and matches the raw summary and PR objectives. The title is 90 characters, which is longer than ideal but still readable.

Full details: Description check

Explanation

The description covers all four template sections. Problem explains the bug in #38864 where isAntigravityCli only matches agy, with reproduction context (ACP registry provider, JSON-RPC -32603 failures). Change states the regex broadening and the test table extension. Scope states this is a small fix to an obvious gap in #38864 and that no separate issue is needed per CONTRIBUTING.md. Verification gives a failing-test-first run, a passing run after the fix, and a check:changed summary. The template's optional agent attribution line is present ("Created with Gemini 4 Neon in T3 Code"). The description is complete and specific.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f60c747 and c8eb64e.

Files selected for processing: 2

  • apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts
  • packages/provider-acp-registry/src/server/adapter.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge

Copy link
Copy Markdown
Member

Thanks for this. T3 Code has its own driver for Antigravity, and that is the supported way to use it: changes that make the same agent work through the ACP Registry are not taken.

T3 Code already supports Antigravity through its own driver, including background-command continuation added in #38864. This change extends an Antigravity-specific exception in the generic ACP Registry path, which falls under the policy to support this agent through its dedicated driver.

The binary-name mismatch you identified explains the reported behavior. Please use the Antigravity provider; if the same failure occurs there, that would be a supported-driver bug we can investigate.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants