Repository navigation
fix(provider-acp-registry): keep Kimi Code threads working while Kimi self-resumes #36181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BarredEwe
wants to merge
5
commits into
pingdotgg:main
Choose a base branch
from
BarredEwe:fix/kimi-post-settle-continuation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−11
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
53046da
fix(provider-acp-registry): keep Kimi Code threads working while Kimi…
BarredEwe 82a213d
test: sync the Kimi regression on the run-1 terminal, not the marker
BarredEwe 070db76
Merge remote-tracking branch 'origin/main' into fix/kimi-post-settle-…
juliusmarminge de4da63
test(acp-registry): drop duplicate Kimi pending-work assertion
juliusmarminge 67f0445
Merge remote-tracking branch 'origin/main' into fix/kimi-post-settle-…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kimi continuation flag does not cover the reported frame sequence.
With the Kimi flavor,
usage_updatefollowed bysession/request_permissioncreates no continuation offer.followAgentWorkStateis set only for Claude, sofollowsAgentWorkStatestays false.wakeOnDetachedRequestis set only for Antigravity CLI.awaitRequestTurnreturns before it callsofferContinuationRun. A continuation is offered only after a later non-emptyagent_message_chunkor a completed or failed tool update.The reported Kimi runs send neither after settle. Those runs stay marked
completedwhile Kimi continues work, so this change does not fix them. The regression test injects anagent_message_chunkafter settle, so it passes without covering the reported sequence.The PR needs either a test that replays the reported sequence, with a change that keeps the run open for it, or a narrower description that limits the change to the
agent_message_chunkcase.