Repository navigation
fix(web): Limits account labels stay readable with five or more accounts - #36137
craigcossairt wants to merge 4 commits into
Conversation
The Limits bar chose its labeled layout from the bar's width alone, so a pool of five accounts got segments too narrow for their names and every name was cut off. The layout now asks whether one account's share of the bar has room for a label, and falls back to the numbered rows when it does not. Limits also uses the full width of the Usage modal, so a wide window labels more accounts. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Limits gains more horizontal space and switches to numbered account legends when individual labels would be cramped. The changes are presentation-only, leaving usage data and limit behavior unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The label clipping is fixed by the per-account breakpoint alone: a bar too narrow to label every account falls back to the numbered rows, which show full names. Widening the Limits page is a separate layout change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nts (pingdotgg#36137) Cherry-picked from upstream pingdotgg#36137 (open PR) into the Korean fork.
pingdotgg#36137 moved the pool container query to one account's share of the bar. The zero-spend-cap cell, added upstream after that PR's base, sits in the same row and still used the old whole-bar breakpoint, so it would switch height and labels apart from its neighbours.
|
This PR conflicts with See the conflict window. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The automated pipeline stopped on this pull request and will not merge it: the fix is written and reviewed, but proving it needs something no worker has:
It stays open for a person to finish or close. |
Problem
With five accounts on one provider, Usage → Limits cuts off every account name in the bar ("Pe…", "Devel…", "Develo…"), so the segments look the same and each one has to be hovered to identify it. This happens even in a 2560px wide window.
Fixes #36134.
Change
Two parts of the same fix:
PoolBarswitched to the labeled layout with@2xl/pool, which looks only at the bar's width. Its container is now sized to one account's share of the bar, so the query asks whether a segment has 11rem for its label. When it does not, the bar falls back to the numbered rows it already uses on narrow screens, which show full names. Bars with up to three accounts keep the old 42rem breakpoint exactly.max-w-5xlinside the 80rem modal, so a five-account bar could never reach the width its labels need, however wide the window.WorkspacePageContainergets afullwidth that Limits uses. The other Usage views stay onwide.docs/user/usage.mdsaid the numbered rows appear "on narrow screens"; it now says they appear when a bar is too narrow to label every account.Scope
Bug fix. The bug is shown in #36134.
#32534 edits lines next to these in
UsageLimitsPooled.tsx. Whichever lands second needs a small rebase, and I will do it if that is this one.Verification
I hit this with five Claude accounts on a 2560×1032 window.
To check the fix I rendered the Limits view inside
AppRouteModalin Chromium through the repo's browser test harness, on made-up accounts ("Personal", "Developer 1" to "Developer 4"), and captured it onmainand on this branch:vp run check:changedpassed format, typecheck, the test beside the change, and the React compiler check. Lint passes on the changed files. Knip could not run in my checkout because the mobile and marketing dependencies are not installed.No test added: this is a layout bug and the captures are the proof.
Not checked: the packaged desktop app. The screenshots come from the component harness, not a running server. The accounts in them are made up because my real Limits page shows account emails.
Claude Fable 5.2 in Claude Code, run from T3 Code.
🤖 Generated with Claude Code