Repository navigation
fix(server): Antigravity commands still running after the reply keep the turn open, and Stop ends them #35073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+203
−0
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
197d7a5
test(server): Antigravity command still running at end_turn is not ma…
juliusmarminge 942f398
fix(server): Antigravity commands still running after the reply keep …
juliusmarminge a53c458
fix(server): Antigravity turns with a launched subagent batch still s…
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finalize deferred turns when the ACP runtime terminates.
When the runtime terminates after
end_turnsettles the prompt,handleRuntimeTerminationAtGenerationinpackages/provider-acp/src/server/adapter.tssetsruntimeRestartRequiredand returns at line 2338 whenfollowsAgentWorkStateis false. Antigravity does not setfollowAgentWorkState, so it takes this return. The inactivity watchdog exits oncepromptWireSettledis done. Deferred finalization waits while the runningexecutetool counts as deferred background work. No inspected path then finalizes the turn or terminalizes its open tool item. The turn can stay active with a running tool. Grok shares this branch, so the change also affects Grok.For a deferred turn whose prompt has settled, finalize the turn as a transport failure and terminalize its open tool items. Keep the restart flag set.
Suggested fix