fix(web): align floating browser preview corners - #10915
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file UI fix that aligns the preview frame, browser content, backdrop, border, and reconnecting overlay to the same existing 12px radius. Geometry, interactions, and browser-surface behavior otherwise remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe mini-player now uses ChangesMini-player corner radius
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change standardizes the mini-player preview corner radius across its visual layers, with no current evidence of a merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What Changed
Use one 12px radius for the floating browser preview's content, border, backdrop, and reconnecting placeholder. The surrounding layers inherit the radius from the preview frame.
Why
The browser surface already uses a fixed 12px corner radius, while the surrounding
rounded-xllayers scale with the interface font. At 17px, the border radius becomes 14.625px, placing its curve inside the browser content and leaving a visible double edge. Sharing the existing content radius keeps all layers aligned across interface font sizes.UI Changes
Captured from the actual T3 Code Electron app with an isolated profile and invented workspace, chat, and browser content. Iris dark theme, 17px interface font, 100% zoom, 1440 × 960 window. Each pair changes only this PR's fix.
Full app captures
Before:
After:
Validation
bun fmtbun lintbun typecheck(full workspace)apps/web:bun run test src/components/preview/previewMiniPlayerLayout.test.ts src/browser/browserSurfaceStore.test.ts— 25 tests passed.Checklist
No animation or interaction behavior changes; a video is not applicable.
Summary by CodeRabbit