fix(web): keep long completed commands compact and expandable - #10898
fix(web): keep long completed commands compact and expandable#10898hiimchinh wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughCompleted commands with newlines or more than 120 characters now display compact labels. Tests verify collapsed summaries and expanded command details. ChangesCommand label rendering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Completed long or multiline commands now use compact labels while retaining expandable details, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What Changed
Completed standalone commands containing line breaks or more than 120 characters use a compact label such as
Ran python3. The full command remains available through expansion, even when it produced no output. Short one-line commands retain their existing labels.Why
Fixes #10879. A successful Python heredoc with no output previously filled the timeline with the entire script and had no expansion control.
Validation: four regression cases red → green, including missing/empty/nonempty output and long single-line commands; 151 affected tests pass; web typecheck and focused lint pass.
UI Changes
Same seeded no-output heredoc in an isolated dev environment. Browser verification confirmed expansion preserves the full command and collapse restores the compact row.
Expansion demo:
command-expansion-demo.webm
Checklist
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit
Bug Fixes
Tests