fix(ssh): clarify password and verification code prompts - #10897
fix(ssh): clarify password and verification code prompts#10897hiimchinh wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe SSH authentication prompt and desktop dialog now describe password or verification-code authentication. Expired prompts use verification-focused wording. Tests cover backend prompt text, dialog copy, SSH key and 2FA wording, and expiration handling. ChangesSSH verification prompt
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to SSH prompts now clearly state that a password or verification code may be required after key authentication, including expired-prompt messaging. The covered wording-only change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What Changed
The SSH dialog and generated prompt now ask for a password or verification code. The hint explains that SSH keys do not remove a server's second-factor requirement.
Why
Fixes #10784. The previous password-only wording misled users whose SSH key was already accepted and whose server was waiting for a TOTP code. Authentication behavior is unchanged.
Validation: TDD red → green; 59 affected tests pass; web/SSH typechecks and focused lint pass.
UI Changes
Real dialog rendered in the web client with a simulated desktop IPC prompt; no live SSH connection was used.
Checklist
Model: GPT-6. Harness: Codex.
Summary by CodeRabbit
User Experience
Bug Fixes