Skip to content

fix(ssh): clarify password and verification code prompts - #10897

Open
hiimchinh wants to merge 1 commit into
pingdotgg:mainfrom
hiimchinh:fix/ssh-verification-copy
Open

fix(ssh): clarify password and verification code prompts#10897
hiimchinh wants to merge 1 commit into
pingdotgg:mainfrom
hiimchinh:fix/ssh-verification-copy

Conversation

@hiimchinh

@hiimchinh hiimchinh commented Sep 9, 2026

Copy link
Copy Markdown

What Changed

The SSH dialog and generated prompt now ask for a password or verification code. The hint explains that SSH keys do not remove a server's second-factor requirement.

Why

Fixes #10784. The previous password-only wording misled users whose SSH key was already accepted and whose server was waiting for a TOTP code. Authentication behavior is unchanged.

Validation: TDD red → green; 59 affected tests pass; web/SSH typechecks and focused lint pass.

UI Changes

Real dialog rendered in the web client with a simulated desktop IPC prompt; no live SSH connection was used.

Before After
Before After

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes

Model: GPT-6. Harness: Codex.

Summary by CodeRabbit

  • User Experience

    • Updated SSH authentication prompts to refer to verification rather than only passwords.
    • Prompts now clearly accept either a password or verification code.
    • Added guidance that SSH keys may replace password entry, while verification codes may still be required for two-factor authentication.
    • Expired verification requests are now identified as expired instead of being presented as password prompts.
  • Bug Fixes

    • Improved SSH authentication messaging when remote login fails, helping users understand what information is needed.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 9, 2026
@hiimchinh
hiimchinh marked this pull request as ready for review September 9, 2026 05:57
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 91b950a8-d9ef-484c-bbbd-f414930cab93

📥 Commits

Reviewing files that changed from the base of the PR and between 6c58362 and d0ada22.

📒 Files selected for processing (4)
  • apps/web/src/components/desktop/SshPasswordPromptDialog.test.tsx
  • apps/web/src/components/desktop/SshPasswordPromptDialog.tsx
  • packages/ssh/src/tunnel.test.ts
  • packages/ssh/src/tunnel.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The SSH authentication prompt and desktop dialog now describe password or verification-code authentication. Expired prompts use verification-focused wording. Tests cover backend prompt text, dialog copy, SSH key and 2FA wording, and expiration handling.

Changes

SSH verification prompt

Layer / File(s) Summary
Update SSH authentication prompt
packages/ssh/src/tunnel.ts, packages/ssh/src/tunnel.test.ts
SSH authentication requests now ask for a password or verification code. The test verifies the prompt produced after authentication failure.
Update desktop verification dialog
apps/web/src/components/desktop/SshPasswordPromptDialog.tsx, apps/web/src/components/desktop/SshPasswordPromptDialog.test.tsx
The dialog uses verification-focused titles, descriptions, helper text, and expiration messages. Tests validate password and verification-code copy and expired-request behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to d0ada

SSH prompts now clearly state that a password or verification code may be required after key authentication, including expired-prompt messaging. The covered wording-only change is ready to merge.

Suggested reviewers: juliusmarminge

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: clarifying SSH password and verification-code prompts.
Description check ✅ Passed The description includes the required What Changed, Why, UI Changes, and Checklist sections. It explains the problem, scope, validation, and UI impact with before-and-after screenshots.
Linked Issues check ✅ Passed The changes satisfy issue [#10784]. They replace password-only wording with verification wording, explain that the value may be a password or verification code, and clarify that SSH keys do not remove…
Out of Scope Changes check ✅ Passed The changes are limited to SSH prompt wording and focused tests for the updated behavior. No unrelated code or authentication-flow changes are present.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SSH 2FA prompt is misleadingly labeled “SSH Password Required”

1 participant