fix(desktop): Install lowercase Linux icons for Wayland overview - #10895
fix(desktop): Install lowercase Linux icons for Wayland overview#10895mwolson wants to merge 1 commit into
Conversation
c72c0cc to
2bfde97
Compare
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds synchronous Linux startup filesystem work and a detached icon-cache process, alongside new desktop-entry icon behavior. It also introduces a file-level suppression for the global-timers static-analysis diagnostic, so the change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
2bfde97 to
532afb5
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughLinux desktop entries now use ChangesLinux icon integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Priority: ➖ Normal Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to Linux AppImage startup now installs the lowercase desktop identity and icon aliases needed for Wayland compositor icon lookup. The desktop-entry and icon-copy behavior are covered, with no current merge-blocking risk identified. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant DesktopPreReadyPlatform
participant linuxDesktopIconInstallOperations
participant APPDIR
participant UserHicolorTree
participant gtk-update-icon-cache
DesktopPreReadyPlatform->>linuxDesktopIconInstallOperations: Build icon installation operations
linuxDesktopIconInstallOperations-->>DesktopPreReadyPlatform: Return packaged and user icon paths
DesktopPreReadyPlatform->>APPDIR: Read packaged icon metadata
DesktopPreReadyPlatform->>UserHicolorTree: Copy changed icons
DesktopPreReadyPlatform->>gtk-update-icon-cache: Refresh the icon cache
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bc99164 to
b395768
Compare
b395768 to
fc4ce90
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Dismissing prior approval to re-evaluate fc4ce90
a73be9a to
958ff97
Compare
958ff97 to
28ff6c3
Compare
31fd156 to
d637097
Compare
The Wayland app id stays com.t3tools.T3Code. Startup copies one 256px t3code.png and com.t3tools.t3code.png so niri and Noctalia can resolve the glyph after an AppImage reinstall. Copies stay synchronous in pre-ready setup so Electron does not become ready before Clerk registers schemes.
d637097 to
e23c2b8
Compare
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
What Changed
Linux AppImage windows keep the T3 icon in niri and Noctalia overview after a Shelly or AppImageLauncher reinstall.
Fixes #10894 linux-wayland-desktop-icon.
Why
Those shells look up the running window by its Wayland app id, then resolve
Icon=and a lowercased id through the icon theme. They do not use the window pixmap. The hidden URL-handler file now hasIcon=t3code, and startup copies one 256pxt3codeicon plus acom.t3tools.t3codealias into the user theme when dest size differs. Qt, GTK, Omarchy, Noctalia, and Dank Material Shell scale that raster. The Wayland id stayscom.t3tools.T3Code, so existing niri and Hyprland capture binds keep working.Copies stay synchronous in pre-ready setup so Electron does not become ready before Clerk registers URL schemes. They skip files that are already the right size so a normal launch is not extra disk work. Icon-cache refresh runs in the background after a real copy so a stuck helper cannot hold the app at startup. The PNGs are on disk before that refresh, so overview can still resolve them if the cache lags.
UI Changes
Overview and workspace tiles should show the T3 icon after an AppImage reinstall. No in-app UI change. This PR does not include screenshots.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes