Skip to content

test(web): cancel queued animation frames during worker cleanup - #10880

Merged
juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-file-worker-test-cleanup-20260909
Sep 9, 2026
Merged

test(web): cancel queued animation frames during worker cleanup#10880
juliusmarminge merged 2 commits into
pingdotgg:t3code/codex-turn-mappingfrom
saphid:fix/v2-file-worker-test-cleanup-20260909

Conversation

@saphid

@saphid saphid commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

The editable-file language test can leave a worker statistics animation frame queued after teardown removes the browser globals. CI then reports an uncaught cancelAnimationFrame is not defined error even when every assertion passes.

Track the test-owned animation frame handles and cancel the remaining callbacks after worker termination and highlighter disposal, before restoring globals. Production behavior is unchanged. This is a prerequisite for #10051. It includes the existing test-only retention correction from #10865 because the current V2 base otherwise fails that server assertion; merge #10865 first. The incremental cleanup remains one web test file.

Verification: all 7 tests in fileEditorLanguageReadiness.test.ts passed with the fix; focused lint and formatting passed. The identical patch was tested in the #10051 composition. A recent direct claude -p --model claude-opus-5 --effort high --tools '' --output-format json review attempt exited 1 because OAuth had expired, before inference; independent review was unavailable.

Model: GPT-6 Astra. Harness: Codex (T3 Code).

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 9, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 9, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 52c3fcb

Macroscope's review found this PR approvable — Both changed files are isolated test code: one updates a retention assertion, and the other cleans up mocked animation-frame callbacks during teardown. No production behavior, product defaults, or static-analysis configuration is changed.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@cursor

cursor Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@macroscopeapp
macroscopeapp Bot dismissed their stale review September 9, 2026 03:49

Dismissing prior approval to re-evaluate 52c3fcb

@juliusmarminge
juliusmarminge force-pushed the t3code/codex-turn-mapping branch from 8187b17 to ada72ce Compare September 9, 2026 06:39
@juliusmarminge
juliusmarminge force-pushed the fix/v2-file-worker-test-cleanup-20260909 branch from 52c3fcb to 4c80bf5 Compare September 9, 2026 18:09
@juliusmarminge
juliusmarminge merged commit ed5dc41 into pingdotgg:t3code/codex-turn-mapping Sep 9, 2026
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants