fix(server): omit native quota for custom Codex providers - #10877
fix(server): omit native quota for custom Codex providers#10877kalvenschraut wants to merge 1 commit into
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained server bug fix that prevents proxy-provided rate limits from being displayed as native Codex subscription quota. Existing native-provider behavior is preserved, and regression tests cover the custom-provider cases. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe Codex provider now reports unsupported usage limits when OpenAI authentication is not required. Tests cover null and ChatGPT accounts with proxy rate-limit data. ChangesCodex usage-limit handling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Custom Codex providers that do not require OpenAI authentication now omit potentially misleading native subscription quota windows while retaining configured hub usage. The intended behavior is covered by focused server tests, with no concrete merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
What changed
A custom Codex provider can expose rate-limit data that does not describe the account serving requests through its proxy. T3 currently presents that data as native subscription quota.
Mark native usage limits unsupported when
requiresOpenaiAuthis false, using the existing API-key exclusion path. Configured hub usage remains available. In Codex, this flag describes the selected provider's authentication requirements, as shown in its account-state implementation.UI
Synthetic browser fixtures generated from baseline and patched provider checks. Before, an unrelated 10% native row appears beside the hub's 80% quota. After, only the hub quota remains.
Verification
requiresOpenaiAuth: false; both report unsupported usage with no windows.Implemented with GPT-6 in Codex; reviewed with claude-fable-5-1 through Claude Code.
Summary by CodeRabbit