You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Branch change totals rerun a failing untracked-file listing on every status poll #34457
I searched existing issues and did not find a duplicate.
I included enough detail to reproduce or investigate the problem.
Area
apps/server
Steps to reproduce
Open a project whose repository has a large untracked tree (more than 5,000 untracked files,
for example other checkouts or build output that is not ignored).
Leave its status shown, so the 30 s status poll runs.
Watch the server traces for GitVcsDriver.review.listUntracked.
Expected behavior
After a failed listing the totals are unavailable, and the same folder is not listed again on every
poll: it is retried after a while, or at once when its untracked set visibly changes.
Actual behavior
readBranchChangeTotals runs git ls-files --others --exclude-standard -z -- <roots> on every
status refresh. ls-files fills the whole untracked directory listing before printing
(fill_directory before show_other_files in builtin/ls-files.c), so the 5,000-path cap applied
afterwards does not bound the work; the 16 MiB output limit or the 30 s timeout ends it. The failure
is swallowed (Effect.orElseSucceed(() => undefined) around the totals), the status refresh itself
succeeds, and the broadcaster's backoff never applies.
In one workspace the server traces showed 103 consecutive failed listings in an hour, each span
lasting 5–30 s (elapsed time), with "Git output exceeded 16777216 bytes" or "Git command timed out".
prepareUntrackedReviewIndex also turns every listing failure into null, which the totals report as
"Too many untracked files to count." even for a timeout or a Git error.
Related: #25558 (slow change totals with a lot of untracked data) and #32463 (bounds the bytes the
review index reads). This issue is about repeating the listing after it failed.
Activity