Modernize dm/pkg

[dveeden]

What problem does this PR solve?

Issue Number: ref #12691

What is changed and how it works?

Check List

Tests

• Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d3hunter for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• dm/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Code Review

This pull request modernizes the codebase by replacing interface{} with any, adopting for range loops for integer iterations, and leveraging standard library packages like slices and maps. However, several critical compilation errors are introduced where wg.Go is called on standard sync.WaitGroup instances, which do not support this method. Additionally, the performance of strings.Builder in basedb.go can be improved by using fmt.Fprintf directly instead of writing formatted strings, which avoids unnecessary allocations.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Using dsn.WriteString(fmt.Sprintf(...)) allocates intermediate strings. Use fmt.Fprintf directly with the strings.Builder to avoid unnecessary allocations and improve efficiency.

Suggested change

	if rawCfg.ReadTimeout != "" {
	dsn += fmt.Sprintf("&readTimeout=%s", rawCfg.ReadTimeout)
	dsn.WriteString(fmt.Sprintf("&readTimeout=%s", rawCfg.ReadTimeout))
	}
	if rawCfg.WriteTimeout != "" {
	dsn += fmt.Sprintf("&writeTimeout=%s", rawCfg.WriteTimeout)
	dsn.WriteString(fmt.Sprintf("&writeTimeout=%s", rawCfg.WriteTimeout))
	}
	if rawCfg.ReadTimeout != "" {
	fmt.Fprintf(&dsn, "&readTimeout=%s", rawCfg.ReadTimeout)
	}
	if rawCfg.WriteTimeout != "" {
	fmt.Fprintf(&dsn, "&writeTimeout=%s", rawCfg.WriteTimeout)
	}

[dveeden]

/cc @kennytm @GMHDBJD

[dveeden]

/retest