CI: Use docker compose instead of docker-compose#12712
Open
dveeden wants to merge 1 commit into
Open
Conversation
The ubuntu-24.04 runner image no longer ships the standalone docker-compose v1 binary, causing the upgrade_dm_via_tiup workflow to fail with "docker-compose: command not found". The image does include the Docker Compose v2 CLI plugin, so switch all invocations to `docker compose`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ti-chi-bot
Bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
ti-chi-bot
Bot
added
size/S
Contributor
Author
|
/cc @OliverS929 @kennytm |
kennytm
approved these changes
Jun 12, 2026
ti-chi-bot
Bot
added
needs-1-more-lgtm
Contributor
Author
|
/retest |
Contributor
Author
|
/cc @D3Hunter |
D3Hunter
approved these changes
Jun 17, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, kennytm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #12542
The "Upgrade DM via TiUP" workflow fails with:
The
ubuntu-24.04runner image no longer ships the standalonedocker-composev1 binary; it only includes the Docker Compose v2 CLI plugin (docker compose).See also: https://github.com/pingcap/tiflow/actions?query=branch%3Amaster+workflow%3A%22Upgrade%20DM%20via%20TiUP%22
What is changed and how it works?
Replace all
docker-compose ...invocations in.github/workflows/upgrade_dm_via_tiup.yamlwithdocker compose ..., which is provided by the runner image out of the box. No installation step is needed and the v1 command style is deprecated anyway.The
docker-compose.ymlfile name references are intentionally unchanged, since Compose v2 still picks up that file name by default.Check List
Tests
workflow_dispatchor the next scheduled run.Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
🤖 Generated with Claude Code