executor: remove unnecessary ordering from full-sampling Analyze requests - #70275
executor: remove unnecessary ordering from full-sampling Analyze requests#702750xPoe wants to merge 1 commit into
Conversation
|
/retest |
📝 WalkthroughWalkthroughV2 full-sampling Analyze scans both unsigned boundary ranges in one unordered request and sorts samples by handle for correlation. Mock execution now fills chunks across multiple ranges. Regression coverage verifies boundary values and empty ranges. An unused Bazel dependency was removed. ChangesUnsigned Handle Sampling
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Poem Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
be804a7 to
6646dc7
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #70275 +/- ##
================================================
- Coverage 76.3220% 73.7856% -2.5365%
================================================
Files 2041 2060 +19
Lines 559145 580132 +20987
================================================
+ Hits 426751 428054 +1303
- Misses 131494 151670 +20176
+ Partials 900 408 -492
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6646dc7 to
90bd9a5
Compare
|
/test mysql-test |
After the Analyze v1 collection path was removed, full-sampling Analyze sorts its V2 samples by handle before computing correlation. Stop preserving scan order and keep unsigned-handle ranges in one request. Add request-shape coverage for the MaxInt64 boundary and regenerate Bazel metadata. Signed-off-by: 0xPoe <poe.liu@pm.me>
90bd9a5 to
3ba454c
Compare
|
/test pull-integration-realcluster-test-next-gen |
0xPoe
left a comment
There was a problem hiding this comment.
🔢 Self-check (PR reviewed by myself and ready for feedback)
-
Code compiles successfully
-
Unit tests added
-
No AI-generated elegant nonsense in PR.
-
Comments added where necessary
-
PR title and description updated
-
Documentation PR created (or confirmed not needed)
-
PR size is reasonable
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terry1purcell, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #63579, ref #70059
Problem Summary:
After #66772 removed Analyze v1 collection, full-sampling Analyze still requests ordered scans and splits unsigned-PK ranges at
MaxInt64, although it sorts collected samples by handle before computing correlation.What changed and how does it work?
KeepOrderand scan both unsigned-handle ranges in one request.Extracted from #69686 and #70055; follow-up to #66772.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
Summary by CodeRabbit
Bug Fixes
Tests
Chores