sync-diff-inspector: filter auto snapshot syncpoint by changefeed#899
Open
pingyu wants to merge 2 commits into
Open
sync-diff-inspector: filter auto snapshot syncpoint by changefeed#899pingyu wants to merge 2 commits into
pingyu wants to merge 2 commits into
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #898
sync-diff-inspector currently resolves
snapshot = "auto"by reading the latest row fromtidb_cdc.syncpoint_v1globally. When multiple TiCDC changefeeds write syncpoint rows into the same downstream table, this can select another changefeed's syncpoint and produce false-positive data mismatches.What is changed and how it works?
This PR adds an optional
syncpoint-changefeedtask config for sync-diff-inspector. When both source and target snapshots are set to"auto"and this option is configured, sync-diff-inspector filterstidb_cdc.syncpoint_v1by that changefeed before selecting the latest syncpoint row. If the option is omitted, the existing global latest-row behavior is preserved.The change also updates the config template, includes the new field in the task config hash, and adds unit coverage for config parsing plus filtered syncpoint lookup behavior.
Check List
Tests
go test ./sync_diff_inspector/config ./sync_diff_inspector/source)Code changes
Release Note