Skip to content

sync_diff_inspector: use hex to compare blob data#709

Open
erwadba wants to merge 2 commits into
pingcap:masterfrom
erwadba:use_hex_compare_blob
Open

sync_diff_inspector: use hex to compare blob data#709
erwadba wants to merge 2 commits into
pingcap:masterfrom
erwadba:use_hex_compare_blob

Conversation

@erwadba

@erwadba erwadba commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #710

What is changed and how it works?

Use hex to compare blob data.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

@ti-chi-bot

ti-chi-bot commented Mar 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from glorv and lichunzhu March 7, 2023 06:44
@glorv glorv requested review from 3pointer and removed request for glorv March 7, 2023 07:10
lichunzhu
lichunzhu reviewed Mar 10, 2023
View reviewed changes

@lichunzhu lichunzhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread sync_diff_inspector/utils/utils.go
if data1.IsNull && data2.IsNull {
if data1.IsNull && data2.IsNull {
if str1 == str2 {
continue

@lichunzhu lichunzhu Mar 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When data1 and data2 are nil, str1 == str2 is always true?

Comment thread sync_diff_inspector/utils/utils.go
if (str1 == str2) && (data1.IsNull == data2.IsNull) {
continue
case mysql.TypeJSON:
var v1, v2 any

@lichunzhu lichunzhu Mar 10, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check whether str1 == str2 first?

@ti-chi-bot

ti-chi-bot Bot commented Sep 8, 2023

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelmdeng michaelmdeng mentioned this pull request May 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pointer 3pointer Awaiting requested review from 3pointer

1 more reviewer

@lichunzhu lichunzhu lichunzhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution needs-rebase size/M status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sync-diff-inspector fix.sql can not execute when data has blob column type.

3 participants

@erwadba @ti-chi-bot @lichunzhu