Skip to content

cloud: changefeed feature is only available upon request#23005

Merged
ti-chi-bot[bot] merged 9 commits into
pingcap:release-8.5from
ginkgoch:fix-essential-changefeed-status
Jun 4, 2026
Merged

cloud: changefeed feature is only available upon request#23005
ti-chi-bot[bot] merged 9 commits into
pingcap:release-8.5from
ginkgoch:fix-essential-changefeed-status

Conversation

@ginkgoch
Copy link
Copy Markdown

@ginkgoch ginkgoch commented Jun 4, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

The changefeed on essential status is updated to private preview. So the documents should be updated accordingly.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 4, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

Hi @ginkgoch. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the TiDB Cloud changefeed documentation to reflect that the feature is now available upon request, providing instructions on how to submit a support ticket, and updates the features table to display a lock icon for this feature. The review feedback recommends style guide adjustments, including using sentence case for headings, adding a blank line before the list in the note block, and maintaining lowercase consistency for the term 'changefeed'.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tidb-cloud/essential-changefeed-overview.md Outdated
Comment thread tidb-cloud/essential-changefeed-overview.md
ginkgoch and others added 4 commits June 4, 2026 13:54
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

@pingyu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd self-requested a review June 4, 2026 06:47
@hfxsd hfxsd self-assigned this Jun 4, 2026
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 4, 2026
Comment thread tidb-cloud/essential-changefeed-overview.md Outdated
Comment thread tidb-cloud/essential-changefeed-sink-to-kafka.md Outdated
Comment thread tidb-cloud/essential-changefeed-sink-to-mysql.md Outdated
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2026
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 4, 2026

/retest

@hfxsd hfxsd changed the title Update changefeed status. cloud: changefeed feature is only available upon request Jun 4, 2026
Comment thread tidb-cloud/essential-changefeed-sink-to-kafka.md Outdated
Comment thread tidb-cloud/essential-changefeed-sink-to-mysql.md Outdated
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 4, 2026

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jun 4, 2026
@hfxsd hfxsd requested a review from qiancai June 4, 2026 07:37
Copy link
Copy Markdown
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread tidb-cloud/essential-changefeed-overview.md Outdated
Comment thread tidb-cloud/essential-changefeed-overview.md Outdated
Comment thread tidb-cloud/essential-changefeed-sink-to-kafka.md Outdated
Comment thread tidb-cloud/essential-changefeed-sink-to-mysql.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2026
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 4, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-06-04 07:40:46.19479166 +0000 UTC m=+427347.265109050: ☑️ agreed by qiancai.
  • 2026-06-04 07:52:10.26236913 +0000 UTC m=+428031.332686520: ☑️ agreed by hfxsd.

@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 4, 2026

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 4, 2026
Comment thread tidb-cloud/essential-changefeed-overview.md
@ti-chi-bot ti-chi-bot Bot merged commit f859122 into pingcap:release-8.5 Jun 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm ok-to-test Indicates a PR is ready to be tested. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants