Skip to content

docs: add statement summary system variables#23001

Open
nolouch wants to merge 2 commits into
pingcap:masterfrom
nolouch:add-docs-about-stmt
Open

docs: add statement summary system variables#23001
nolouch wants to merge 2 commits into
pingcap:masterfrom
nolouch:add-docs-about-stmt

Conversation

@nolouch
Copy link
Copy Markdown
Member

@nolouch nolouch commented Jun 3, 2026

What is changed

Add English documentation for two statement summary system variables, corresponding to pingcap/docs-cn#21694:

  • tidb_stmt_summary_group_by_user
  • tidb_stmt_summary_persist_evicted

Updated files:

  • statement-summary-tables.md
  • system-variables.md
  • system-variable-reference.md

Check List

Tests:

  • ./scripts/markdownlint statement-summary-tables.md system-variable-reference.md system-variables.md
  • git diff --check -- statement-summary-tables.md system-variable-reference.md system-variables.md

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qiancai for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for two new system variables introduced in TiDB v8.5.7: tidb_stmt_summary_group_by_user and tidb_stmt_summary_persist_evicted. The changes span across statement-summary-tables.md, system-variable-reference.md, and system-variables.md. The review comments suggest rewriting several sentences to use the active voice, reducing wordiness, and using "who" instead of "that" when referring to users, in alignment with the repository's documentation style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread statement-summary-tables.md Outdated
Comment thread statement-summary-tables.md Outdated
Comment thread statement-summary-tables.md Outdated
Comment thread system-variables.md Outdated
Comment thread system-variables.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant