Skip to content

Add optimized batch update of hotspot indexes to release-6.0.0-dmr - #9511

Merged
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Oreoxmt:releasenote-SHARD_INDEX
May 26, 2022
Merged

Add optimized batch update of hotspot indexes to release-6.0.0-dmr#9511
ti-chi-bot merged 5 commits into
pingcap:masterfrom
Oreoxmt:releasenote-SHARD_INDEX

Conversation

@Oreoxmt

@Oreoxmt Oreoxmt commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What is changed, added or deleted? (Required)

Add optimized batch update of hotspot indexes to release-6.0.0-dmr.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. needs-cherry-pick-release-6.0 v6.1 This PR/issue applies to TiDB v6.1. labels May 18, 2022
@Oreoxmt Oreoxmt self-assigned this May 18, 2022
@ti-chi-bot

ti-chi-bot commented May 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
ti-chi-bot requested a review from TomShawn May 18, 2022 02:55
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2022
@Oreoxmt Oreoxmt mentioned this pull request May 18, 2022
Merged
13 tasks
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2022
@Oreoxmt
Oreoxmt requested review from TonsnakeLin and cfzjywxk May 18, 2022 03:08
TonsnakeLin
TonsnakeLin reviewed May 20, 2022
View reviewed changes
Comment thread releases/release-6.0.0-dmr.md Outdated
Comment thread releases/release-6.0.0-dmr.md Outdated
@Oreoxmt
Oreoxmt requested a review from TonsnakeLin May 24, 2022 05:23
@Oreoxmt

Oreoxmt commented May 25, 2022

Copy link
Copy Markdown
Contributor Author

/rebase

Oreoxmt and others added 2 commits May 25, 2022 05:21
@Oreoxmt
add Optimized batch update of hotspot indexes
8ccbbad
@Oreoxmt @TonsnakeLin
Apply suggestions from code review
a3477ec 
Co-authored-by: TonsnakeLin <87681388+TonsnakeLin@users.noreply.github.com>
@TomShawn
TomShawn force-pushed the releasenote-SHARD_INDEX branch from 30f5207 to a3477ec Compare May 25, 2022 05:21
@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
Oreoxmt
Oreoxmt commented May 25, 2022
View reviewed changes
Comment thread releases/release-6.0.0-dmr.md Outdated
TomShawn
TomShawn reviewed May 25, 2022
View reviewed changes
Comment thread releases/release-6.0.0-dmr.md Outdated
@Oreoxmt @TomShawn
Apply suggestions from code review
233fd58 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed May 25, 2022
View reviewed changes
Comment thread releases/release-6.0.0-dmr.md Outdated
@Oreoxmt @TomShawn
Apply suggestions from code review
728dec6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn approved these changes May 25, 2022
View reviewed changes

@TomShawn TomShawn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@Oreoxmt Oreoxmt closed this May 25, 2022
@Oreoxmt Oreoxmt reopened this May 25, 2022
@TomShawn

TomShawn commented May 26, 2022

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented May 26, 2022

Copy link
Copy Markdown
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn

TomShawn commented May 26, 2022

Copy link
Copy Markdown
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@TomShawn

TomShawn commented May 26, 2022

Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot

ti-chi-bot commented May 26, 2022

Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 728dec6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@ti-chi-bot
ti-chi-bot merged commit 3375c8f into pingcap:master May 26, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2022
Merged
13 tasks
@ti-chi-bot

ti-chi-bot commented May 26, 2022

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created: #9605.

ti-chi-bot added a commit that referenced this pull request May 26, 2022
@ti-chi-bot
Add optimized batch update of hotspot indexes to release-6.0.0-dmr (#…
2eae13b 
…9511) (#9605)
This was referenced Jun 7, 2022
Merged
Merged
@Oreoxmt
Oreoxmt deleted the releasenote-SHARD_INDEX branch June 8, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk
2 more reviewers
@TomShawn TomShawn TomShawn approved these changes
@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.1 This PR/issue applies to TiDB v6.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Oreoxmt @ti-chi-bot @TomShawn @TonsnakeLin