fix: expose short margin liquidations before script evaluation - #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short liquidations were settled after the close-time strategy calculation. A strategy could read a retired position, suppress a flat-only entry, or attach a bracket using the old entry price. Settle the supported short margin checkpoint before the script and retire a fully closed position's old bracket before new orders are placed.
The shared engine path selects by broker state and order ownership, without strategy, symbol, date, or benchmark-ID conditions. Its measured scope is an ordinary market-origin short of at most one unit, 100% margin, a fractional lot step, no fees/slippage/FX conversion, and at most one own regular priced bracket. Liquidation arithmetic, sizing rules, grading metrics, verifier, harness, population, and tapes are unchanged.
The README now reports the round 23 overall and per-lane scoreboard and current test inventory. Remove four retired research files under
validation-adhoc/4emarsi-commission-slippage-ethusdt, replacing documentation references with permanent links to their published Git history. Those files are not runtime/build or registry inputs; all four graded 4emarsi corpus probes remain intact and excellent. The FX test changes only a comment citation.Validation on frozen
00938e4ca48ae6b37e6979f9c6b0f9a2969b0e79:Codegen remains pinned to
3fd97fe28abd7b191cb376d9f5db4e056fcfae4b. No product release or compute-plane deployment is included.Formal Cloud Run gate
pineforge-pr-gate-dzccj: PASS, target score +2, 704 hard probes with zero regressions or tolerated exceptions. Gated snapshot:51d6e41d27fcca7e021d3aa7f180002c0f0b662f4ee221869915bb2fb6c4de5f.