fix: preserve representable 0.01-lot grid points in money sizing - #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Division by binary64
0.01could floor a quantity one lot below a grid point that the input already represents. The money-sizing helper now checks an exact scale-of-100 candidate and accepts it only when the reconstructed grid quantity does not exceed the input. This adds no epsilon and preserves the existing under-floor controls and other lot sizes.Validated on engine
a03ac6d3fb42df5af1db9e39727daf450b2fb71fwith codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-h59tq: PASS, target score +1, and zero regressions or tolerated exceptions across 704 hard probes.Grading metrics, thresholds, tolerances, verifier, harness, tapes and population are unchanged. An unconditional scale-of-100 version was rejected because it broke an existing TradingView control; the guarded version preserves that control.
Candidate snapshot:
f9f708d622270b207b1234b8f8031a237a3499391a29e6377233c3d5d90bfc9b(788,855 bytes).