fix: release uniquely owned bracket slots while preserving FIFO history - #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bracket that fully closed its own uniquely identified lot could leave its pyramid slot occupied, incorrectly rejecting a later entry. The ordinary two-slot FIFO path now releases that slot only after proving the owner lot retired and one distinct lot remains. A lot previously reduced by a foreign or ambiguous bracket keeps its slot history, preserving the existing cross-ID FIFO rejection behavior.
Validated on engine
6b1f4f12f4da40d172b54d41d81c7e8e84ef8d52with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-m99r6: PASS, target score +1, and zero regressions or tolerated exceptions across 704 hard probes.The target adds exactly the missing November 19 entry and its November 20 exit, with no existing economic rows removed. Existing split-versus-combined row differences in two trades and the final range-end mark remain; this is not a claim of complete economic identity.
Grading metrics, thresholds, tolerances, verifier, harness, tapes and population are unchanged. Existing ambiguous same-ID, cross-owner FIFO, ANY, POOC, COOF, magnifier and streaming paths retain their prior release rules.
Candidate snapshot:
6608bf86d773f16b7120a40488e57ee63c5f922c57c95e602c550e69e50c796b(788,854 bytes).