fix: omit partial initial daily bars from OTC security requests - #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A forex or CFD intraday run starting mid-session counted an incomplete daily bar toward
request.securityindicator warmup. Daily ATR could therefore become available one session too early. The engine now excludes that initial partial daily bucket on the single-feed historical path and applies the same boundary to lookahead projections, using the actual session open to preserve OANDA's earlier daily timestamp.Validation on engine
e729b1432c1a5fdc7e95ac33d1e879232b55e37fwith codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-4686q: PASS, target score +2, and zero regressions or tolerated exceptions across 704 hard probes.The target has 244 trades and 488 entry/exit rows; 480 economic rows match TradingView exactly and eight residual timing/price differences remain. The excellent grade does not imply complete economic identity.
Grading metrics, thresholds, tolerances, verifier selection, harness, tapes and population are unchanged. Existing native/auxiliary feed, weekly/monthly, explicit warmup and streaming rules remain in place.
Candidate snapshot:
73babb95ef95308dff77370d9babb008ab0818217c4513363d276ad54d5d8796(788,852 bytes).