fix: preserve residual long after repeated percent sell entry - #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeating a default-percent short entry with the same ID in one bar could close the entire existing long and open a new short. For the confirmed ordinary next-open case, the engine now executes the frozen sell quantity, preserves any long remainder and its bracket lifecycle, and cancels later sell siblings. Exact replacement provenance and risk-direction guards preserve the other order paths.
Validated on engine
c022c40ebca11fd73a087b563c30fb813046fbe8with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-hvgzv: PASS, target score +1, and zero regressions or tolerated exceptions across 704 hard probes. Result: 4,159 excellent / 30 strong / 1 moderate.Grading metrics, thresholds, tolerances, verifier, harness, tapes and population are unchanged. The buy-side replacement behavior remains outside this repair.
Candidate snapshot:
0b80b0726dea11aa41fb4b1adf828c527f6a2694f8733aff1c0c3fff0bf017e9(788,862 bytes).