fix: use broker close tick for pinned POOC short exits - #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluate a reissued full short exit against the broker's rounded close under ordinary
process_orders_on_close. The previous raw-close comparison could fill a limit one bar early or a stop one bar late. Preserve the original full-percent request and ignore only exit siblings whose parent never filled in the current position; active competing orders retain the existing behavior.Validation on engine
113ec87258f02cfee12db57f89b5631b0bb4bda9with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-2vzwg: PASS against baseline86049406d8f675d7ad237f519d1a023ae21f6096, target score +1, zero regressions or tolerated exceptions across 704 hard probes. Result: 4,157 excellent / 32 strong / 1 moderate.The change is limited to the pinned older single-short-position exit shape. Order levels, fill calculations, grading metrics, thresholds, tolerances, verifier, harness, tapes and population are unchanged.
Candidate snapshot:
0099071a96ee899f19f2ac5c655b27d7161c51348d359866076dbaf2d5bb7c5d(788,857 bytes).