fix: allow pinned COOF market-entry limit recross - #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a full long limit exit armed by a calc-on-order-fills market entry at the first high to fill when price recrosses its level later in the bar. Whole-entry-bar suppression previously delayed these exits until the next bar. The exception is tied to the actual opening fill and its first callback; existing path, stop and competing-order guards remain in force.
Validation on engine
86049406d8f675d7ad237f519d1a023ae21f6096with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-8bcpn: PASS against baselinedd98f02ed492f64ae8b48358117c83530f88ae74, target score +2, zero regressions or tolerated exceptions across 704 hard probes. Result: 4,156 excellent / 33 strong / 1 moderate.The rule is limited to the pinned historical, single-lot long market-entry case. Grading metrics, thresholds, tolerances, verifier, harness, tapes and population are unchanged.
Candidate snapshot:
1544c156154fccd4789afa50ffc7db900c49e34f63d36fdbc6dc213cb31661bd(788,854 bytes).