fix: preserve reversal carry and pinned COOF exit behavior - #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the one-unit closing carry for the pinned default-100% reversal after a same-signal close-point margin call. Let a carried full COOF exit reach an outward-rounded chart extreme while preserving the raw path cursor. Settle already-resting long stop siblings on one adverse segment before one script recalculation, retaining each fill price and broker fill event.
Validation on engine
dd98f02ed492f64ae8b48358117c83530f88ae74with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-68lz2: PASS, zero regressions or tolerated exceptions across 704 hard probes, target score +2. Result: 4,154 excellent / 35 strong / 1 moderate.The fixes retain their TradingView-pinned order and execution-mode guards. EURUSD taro retains PnL P90 of 0.0007; ES1 daily jenmb has zero canonical P90 errors. Grading metrics, thresholds, tolerances, verifier, harness and population are unchanged.
Candidate snapshot:
23fc951fbb02d9f38ca4875ef1aceccb5bf570b79285651afb1419ad399eb917(788,848 bytes), compared with baseline engine76518c6b79cea8410b462a892994deaebd4bdc9a.