Fix POOC margin calls, trailing exits and gap admission - #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process the pinned carried-position POOC margin call before close-time strategy logic, so percentage closes see the reduced position. Preserve the pre-bar trailing extreme when POOC scans an unchanged retained exit again. Admit the pinned default-entry gaps using the rounded affordable-price rule and run their existing opening-margin check.
Validation on engine
76518c6b79cea8410b462a892994deaebd4bdc9awith codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-z7kx8: PASS, zero regressions or tolerated exceptions across 704 hard probes, target two-band score +5. Result: 4,152 excellent / 37 strong / 1 moderate.p181 EURUSD retains canonical PnL P90 of 0.0006; the other four converted probes have all canonical P90 errors at zero. Taro EURUSD's separate margin-call reversal residue remains unchanged.
Candidate snapshot:
17196386841c48057f85b5a10876ffd7f1554b7d0fbd67739e46af9e992e6414(788,853 bytes), compared with baseline enginec63be8880c49576300b2a53d1889a2e1c34dfb29.