Match rounded money for close-first entries and opening margin calls - #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply TradingView's rounded signal-cost check when an opposite entry follows a same-bar close. Use rounded required money at the existing opening-margin checkpoints, including before a priced exit. The pinned May 28 trim becomes 62.32 instead of 62.28; the June 9 opening now includes the missing one-unit margin call.
Validation on engine
c63be8880c49576300b2a53d1889a2e1c34dfb29with codegen3fd97fe28abd7b191cb376d9f5db4e056fcfae4b:pineforge-pr-gate-xsrx6: PASS, zero regressions or tolerances across 704 hard probes, target two-band score +2. No tier drops or new moderate; result is 4,147 excellent / 42 strong / 1 moderate.Taro EURUSD remains strong and unresolved: its canonical match rate changes from 97.6% to 97.5% and PnL P90 from 0.0009 to 0.001, while the canonical trade-count gap improves from 5 to 3. These mixed metrics are retained explicitly.
Candidate snapshot:
1fccc6441684a1a75911ec16e8f9e0477b0b6a1213788280f8735be56eacf92a(788,867 bytes), compared with baseline engineff4a6b897b66a97d78a7c5aa8ca4b02b6804bd94.