[Data Object Editor] make child grid and variant grid detachable#3862
Open
ValeriaMaltseva wants to merge 4 commits into
Open
[Data Object Editor] make child grid and variant grid detachable#3862ValeriaMaltseva wants to merge 4 commits into
ValeriaMaltseva wants to merge 4 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2514
What was fixed
Made the children grid (in the object editor) and the variant grid detachable, so they can be popped out into the bottom widget area — the same way the Preview and Versions tabs already work.
childrenTabclone ofTAB_LISTING) →isDetachable = trueTAB_VARIANTS) →isDetachable = trueThe folder editor's shared "View" listing tab is intentionally left non-detachable: the flag is set on the object editor's
childrenTabclone rather than on the sharedTAB_LISTING, so it does not leak to the folder editor.Why
Requested in #2514 — users want to detach these grids into their own area for a larger working view, consistent with the other detachable editor tabs.