Add type check for DataObjectSearchResultItem

[sandeeep-prajapati]

Pull Request Overview

This PR fixes an issue in IconService::getClassIcon() where getClassDefinitionIcon() could be called on objects that do not support the method.

Changes

• Added an instanceof DataObjectSearchResultItem check before accessing getClassDefinitionIcon().
• Ensures the icon is only resolved for supported object types.
• Prevents potential runtime errors caused by calling getClassDefinitionIcon() on unsupported objects.

Before

if ($dataObject->getClassDefinitionIcon() !== null) {

After

if (
    $dataObject instanceof DataObjectSearchResultItem &&
    $dataObject->getClassDefinitionIcon() !== null
) {

Why?

getClassIcon() may receive different object types, but getClassDefinitionIcon() is only available on DataObjectSearchResultItem. This guard ensures the method is invoked only when supported, making the service more robust and preventing unexpected errors.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[Copilot]

Pull request overview

This PR hardens IconService::getClassIcon() by guarding the call to getClassDefinitionIcon() with an instanceof DataObjectSearchResultItem check. Since getClassIcon() accepts a DataObjectSearchResultItem|DataObject union, and getClassDefinitionIcon() is only defined on DataObjectSearchResultItem, invoking it on a plain DataObject (e.g. a Concrete object or folder that falls through the first branch) would trigger a runtime error. The short-circuiting && ensures the method is only reached for supported types, which is a correct and well-targeted fix that preserves existing behavior for search-result items.

Changes:

• Added an instanceof DataObjectSearchResultItem guard before accessing getClassDefinitionIcon() in getClassIcon().

[martineiber]

LGTM