[Studio] Fix classification store key picker#631
Merged
markus-moser merged 3 commits intoJun 10, 2026
Conversation
The Data Target "Classification Store" key picker couldn't be used: no selection control was rendered, the "Apply selection" button stayed disabled, the applied key was never displayed, and several UX issues remained. - Render a (single-select) selection control and resolve tanstack's selection updater so a row can actually be selected and applied. - Give skeleton rows unique keys so they don't get stranded over real data. - Pass the stored keyId back to the picker so the applied key is shown, and pre-seed the key-name cache on apply so it appears immediately. - Make the grid full width and show the grid skeleton while (re)fetching, including during search. - Reset search, paging and selection each time the modal opens. - Allow opening the picker without a transformation result type (drop the gating + tooltip; the backend returns all keys when no type is given). - Keep the selected classification store field when the transformation result type changes (only the key is reset, not the field).
|
markus-moser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #626 — the Data Target "Classification Store" key picker was unusable.