test(oom-bypass): CI-aware readiness deadline + dead-child fail-fast#271
Conversation
tests/oom_bypass_closure.rs readiness had a fixed 30s connect deadline with no CI allowance and no liveness check on the spawned server: test_case_e_cross_db_copy_oom lost the 30s race on a loaded macOS CI runner and a crashed child burned the full deadline with a useless "connection refused" panic. Mirror the tests/sigterm_shutdown.rs remedy from PR #264: - wait_ready(guard, dir, port) polls child.try_wait() between bounded 1s connect windows and panics immediately with moon.stderr.log / moon.stdout.log tails if the server exited; - readiness deadline doubles to 120s under CI; - Client::connect became Client::try_connect(port, window) returning Option so the caller owns the deadline policy. All 8 tests pass locally (release-fast). author: Tin Dang <tindang.ht97@gmail.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Fixes the flake that failed #269's macOS run:
test_case_e_cross_db_copy_oomuses a fixed 30s connect deadline — a loaded macOS runner lost the race, and a crashed child would burn the whole deadline before a useless "connection refused" panic.Same pattern as #264 (sigterm/bgsave harnesses):
wait_readyfail-fasts on a dead child viatry_wait(), surfacing server log tailsCITest-harness-only change; all 8 tests pass locally.