fix(server): cfg-gate accept-backoff TEST libc errnos for Windows#243
Conversation
Follow-up to the accept_backoff Windows fix in PR #242: the module's resource_exhaustion_classification unit test also referenced libc::EMFILE/ENFILE/ECONNABORTED, so the main-push Windows check kept failing E0433 on the test build. cfg-split the test the same way as the function under test: unix keeps the libc errnos, Windows uses WSAEMFILE (10024) / WSAENOBUFS (10055) / WSAECONNABORTED (10053). The Windows job runs only on main pushes (skipped on PRs), which is why neither the original break (PR #230) nor the partial fix could be validated pre-merge. author: Tin Dang
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe ChangesTest cfg-splitting fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Related Issues: None specified Related PRs: None specified Suggested labels: windows, tests, changelog Suggested reviewers: None specified 🐰 A rabbit hopped across the platform divide, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #242's Windows fix: the
resource_exhaustion_classificationunit test inaccept_backoff.rsalso referenceslibc::errnos, so the main-push Windows check still fails E0433 on the test build (the Windows job is skipped on PRs — neither the original break from #230 nor the partial fix could be caught pre-merge). The test is now cfg-split the same way as the function under test: unix keeps the libc errnos, Windows uses WSAEMFILE (10024) / WSAENOBUFS (10055) / WSAECONNABORTED (10053).Verified:
cargo test --lib server::accept_backoff4/4, fmt clean, andgrepconfirms everylibc::site in the file is now behind#[cfg(unix)].Summary by CodeRabbit