Skip to content

Provide proper return types to Findable#684

Merged
stephangroen merged 1 commit intopicqer:mainfrom
curry684:return-types-findable
Dec 19, 2025
Merged

Provide proper return types to Findable#684
stephangroen merged 1 commit intopicqer:mainfrom
curry684:return-types-findable

Conversation

@curry684
Copy link
Copy Markdown
Contributor

@curry684 curry684 commented Dec 1, 2025

Alternative approach to #683

@curry684
Copy link
Copy Markdown
Contributor Author

curry684 commented Dec 1, 2025

Note: actually returning static from a function is not allowed in PHP 7 hence why find also has the phpdoc return.

@curry684
Copy link
Copy Markdown
Contributor Author

curry684 commented Dec 9, 2025

Can we merge this?

@stephangroen stephangroen merged commit a907246 into picqer:main Dec 19, 2025
2 checks passed
@curry684 curry684 deleted the return-types-findable branch December 19, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants