Add boolean input param to enable WAL mode#1395
Open
TimothyAllman wants to merge 2 commits into
Open
Conversation
dantownsend
reviewed
Jun 24, 2026
dantownsend
left a comment
dantownsend
left a comment
Member
There was a problem hiding this comment.
This looks good - thanks!
Just one suggestion about making it more flexible.
| path: str = "piccolo.sqlite", | ||
| log_queries: bool = False, | ||
| log_responses: bool = False, | ||
| enable_wal_mode: bool = False, |
Member
There was a problem hiding this comment.
What do you think of changing this to:
journal_mode: Literal['DELETE', 'TRUNCATE', 'PERSIST', 'MEMORY', 'WAL', 'OFF'] | None = NoneIt provides a bit more flexibility if people want alternative journal modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there
adding boolean input to enable WAL mode
as mentioned in this discussion #1394 (comment)
let me know if I mis-interpretted anything or if anything needs more work
I was thinking as a first pass (this PR) just add the boolean input param.
then as a second pass, maybe generalize for any PRAGMA statment (wondered if you had any ideas or first thoughts as to how you would want to go about this)
love the work on piccolo
Many thanks