chore: delete the 25,984-line dead duplicate under examples/src - #50
Open
physics515 wants to merge 1 commit into
Open
chore: delete the 25,984-line dead duplicate under examples/src#50physics515 wants to merge 1 commit into
physics515 wants to merge 1 commit into
Conversation
`crates/mummu/examples/src/` was a stale copy of `crates/mummu/src/`, added by commit 769d218 ("stuff", 2026-08-31) outside the PR process. Cargo never built it, and it had already diverged from the real source -- so it was pure weight that silently polluted every grep over the crate. It cost the 2026-09-07 run a wrong read of where `TensorSnapshot` is used, and doubled the apparent site count when auditing `HybridKv` and `ParamSrc`. Proof the delete is inert: - no `main.rs` under the tree, so example auto-discovery never made it a target; - no `[[example]]` entry in any Cargo.toml (auto-discovery only) and no `include!` / `#[path]` reference from outside the tree; - `cargo metadata` reports the SAME 30 example targets before and after, none of them named `src`. 40 files, 25,984 deletions. `cargo check --workspace --all-targets` is green with 0 errors and 0 warnings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crates/mummu/examples/src/was a stale copy ofcrates/mummu/src/, added bycommit
769d218("stuff", 2026-08-31) outside the PR process. Cargo never builtit, and it had already diverged from the real source — so it was pure weight that
silently polluted every
grep/rgover the crate. It cost the 2026-09-07 nightlya wrong read of where
TensorSnapshotis used, and doubled the apparent sitecount when auditing
HybridKvandParamSrc.40 files, 25,984 deletions.
Proof the delete is inert
Three independent checks, because deleting 26k lines deserves more than "it looked
unused":
main.rsanywhere under the tree — Cargo's example auto-discovery onlypromotes an
examples/subdirectory to a target when it contains one, so thiswas never a build target.
[[example]]entry in anyCargo.toml(auto-discovery only), and noinclude!or#[path]reference to the tree from outside it.cargo metadatareports the same 30 example targets before and after thedeletion, none of them named
src.Verification
cargo check --workspace --all-targetsEXIT=0— 0 errors, 0 warningscargo metadataexample targets--all-targetsis the precise instrument here: it type-checks every lib, bin,test, bench and example, so any surviving reference to the deleted files would
have failed the build. It ran cold, compiling the full burn/cubecl/Tauri graph.
The full
cargo test --workspacesuite was green at the parent commite7e430c(481 passed / 0 failed / 76 ignored across 48 binaries) and is re-running on this
branch; since this commit deletes only files that nothing compiles, no test
behaviour changes.
Closes the
[ ]filed in ROADMAP P0 by the 2026-09-07 nightly, now ticked withthe proof recorded inline.
🤖 Generated with Claude Code