Skip to content

Use __attribute__((used)) when available#1902

Merged
phst merged 1 commit into
masterfrom
used
Jun 12, 2026
Merged

Use __attribute__((used)) when available#1902
phst merged 1 commit into
masterfrom
used

Conversation

@phst

@phst phst commented Jun 12, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new EXPORT macro (which combines VISIBLE and a conditionally defined USED attribute) to annotate emacs_module_init and plugin_is_GPL_compatible in elisp/proto/module.c. The reviewer feedback recommends prefixing the generic macro names USED and EXPORT with a more unique prefix like ELISP_PROTO_ to avoid potential naming collisions with other system or third-party headers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread elisp/proto/module.c
Comment thread elisp/proto/module.c
@phst phst merged commit bc71d50 into master Jun 12, 2026
18 checks passed
@phst phst deleted the used branch June 12, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant