Conversation
Member
|
@henderkes Can you test building with clang using the php/php-src#23992 branch and the |
Author
|
This is showing a lot of small defects in the 32 bit clang build on Windows. I tended to 64 bit for 8.6, but 32 bit only happened in non-pgo CI. |
Author
|
https://github.com/henderkes/php-windows-builder/actions/runs/36914869294 Green at last. Now to dissect what actually is a bug fix for 8.6 and what is not. Assuming windows-x32 is still a supported target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builds on php/php-src#23992