Conversation
Sjord
commented
Oct 2, 2026
Sjord
commented
Oct 2, 2026
Contributor
Author
TimWolla
requested changes
Oct 2, 2026
Member
There was a problem hiding this comment.
This test should likely be marked as slow.
Member
There was a problem hiding this comment.
From what I see this is not resolved.
Don't accept leading zeroes on rounds int. Changed bad test vectors to be more like v2 good hashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the discussion on the 72-byte limit of bcrypt, Tim suggested implementing passlib's bcrypt-sha256. That does a HMAC of the password before passing it to bcrypt, solving the 72-byte limit and also the null-byte problem.
This implements bcrypt-sha256 as an algorithm to pass to
password_hash/_verify.