Repository navigation
Conversation
Fake closures for internal functions could not return that they were equal due to the zif_handler being wrapped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is effectively a follow-up to #22145 to properly fix #22118 with internal functions.
It turns out that to prevent memory leaks for fake closures of internal functions, the zif_handler is changed to
zend_closure_internal_handlerand the true zif_handler is stored in theorig_internal_handlerfield of the zend_closure struct.So
return func1->internal_function.handler == func2->internal_function.handler;could never return true for internal functions.We need to keep
zend_fcc_closure_equals_ex()as the ABI is frozen, but it probably makes sense to clean this all up in master.I'll definitely write some docs about zend_closure after I finished the FCI/FCC ones as this is incredibly confusing.