Skip to content

ext/intl: correct the 8.4.0 Error normalization, it only concerns cloning #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lacatoire wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/intl: correct the 8.4.0 Error normalization, it only concerns cloning #5798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions appendices/migration84/other-changes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,9 +551,12 @@
<title>Intl</title>

<simpara>
The behaviour of Intl class has been normalized to always throw
<exceptionname>Error</exceptionname> exceptions when attempting to use
a non-initialized object, or when cloning fails.
Cloning an Intl object consistently throws an
<exceptionname>Error</exceptionname> when the clone cannot be performed,
either because the object has not been initialized, or because the
underlying ICU clone operation failed. Formerly, most of these classes
threw an <exceptionname>Exception</exceptionname> instead, and
<classname>Spoofchecker</classname> raised a fatal error.
</simpara>
</sect3>

Expand Down
12 changes: 12 additions & 0 deletions reference/intl/book.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,18 @@
</listitem>
</itemizedlist>

<note>
<simpara>
As of PHP 8.4.0, cloning an Intl object consistently throws an
<exceptionname>Error</exceptionname> when the clone cannot be performed,
either because the object has not been initialized (created without
invoking its constructor), or because the underlying ICU clone operation
failed. Formerly, most of these classes threw an
<exceptionname>Exception</exceptionname> instead, and
<classname>Spoofchecker</classname> raised a fatal error.
</simpara>
</note>

<!-- {{{ Links -->
<section xml:id="intl.links">
<title>Links</title>
Expand Down