Fix and factor out the SNMPv3 security parameter descriptions - #5228
Open
lacatoire wants to merge 1 commit into
Open
Fix and factor out the SNMPv3 security parameter descriptions#5228lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
lacatoire
force-pushed
the
fix/issue-3690-snmp3-privacy-protocol
branch
from
August 25, 2026 10:27
9b7a4ad to
bbfaf72
Compare
lacatoire
force-pushed
the
fix/issue-3690-snmp3-privacy-protocol
branch
from
August 25, 2026 10:46
bbfaf72 to
fbf7774
Compare
lacatoire
force-pushed
the
fix/issue-3690-snmp3-privacy-protocol
branch
from
August 25, 2026 11:21
fbf7774 to
b4ae554
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3690
snmp3_real_walk()describedprivacy_protocolwith the authentication protocols, which it does not accept. 1051736 had landed on the wrongvarlistentry, overwritingprivacy_protocoland leavingauth_protocolstale, and had skippedsnmp3_set()andSNMP::setSecurity()entirely. All of it is repaired here, including the two missing 8.1.0 changelog entries.These descriptions were duplicated by hand across six pages, which is how one commit desynchronised four of them unnoticed for three years. They are now defined once in
language-snippets.ent, following the existingpgsql.parameter.*andpgsql.changelog.*patterns.The wording is unchanged from the pages that were already correct, so
snmp3_get(),snmp3_getnext()andsnmp3_walk()render identically. Checked against a real SNMPv3 agent:DES,AESandAES128are accepted forprivacy_protocol,MD5,SHA,SHA256andSHA512forauth_protocol, anything else throws aValueError.Translations are unaffected:
en/language-snippets.entis layered as a fallback, so pages build whether or not they adopt the entities, rendering English until each translation defines its own, as was done forpgsql.parameter.*.