Skip to content

Fix and factor out the SNMPv3 security parameter descriptions - #5228

Open
lacatoire wants to merge 1 commit into
php:masterfrom
lacatoire:fix/issue-3690-snmp3-privacy-protocol
Open

Fix and factor out the SNMPv3 security parameter descriptions#5228
lacatoire wants to merge 1 commit into
php:masterfrom
lacatoire:fix/issue-3690-snmp3-privacy-protocol

Conversation

@lacatoire

@lacatoire lacatoire commented Jan 30, 2026

Copy link
Copy Markdown
Member

Fixes #3690

snmp3_real_walk() described privacy_protocol with the authentication protocols, which it does not accept. 1051736 had landed on the wrong varlistentry, overwriting privacy_protocol and leaving auth_protocol stale, and had skipped snmp3_set() and SNMP::setSecurity() entirely. All of it is repaired here, including the two missing 8.1.0 changelog entries.

These descriptions were duplicated by hand across six pages, which is how one commit desynchronised four of them unnoticed for three years. They are now defined once in language-snippets.ent, following the existing pgsql.parameter.* and pgsql.changelog.* patterns.

The wording is unchanged from the pages that were already correct, so snmp3_get(), snmp3_getnext() and snmp3_walk() render identically. Checked against a real SNMPv3 agent: DES, AES and AES128 are accepted for privacy_protocol, MD5, SHA, SHA256 and SHA512 for auth_protocol, anything else throws a ValueError.

Translations are unaffected: en/language-snippets.ent is layered as a fallback, so pages build whether or not they adopt the entities, rendering English until each translation defines its own, as was done for pgsql.parameter.*.

@lacatoire lacatoire closed this Mar 2, 2026
@lacatoire lacatoire reopened this Aug 21, 2026
@lacatoire
lacatoire force-pushed the fix/issue-3690-snmp3-privacy-protocol branch from 9b7a4ad to bbfaf72 Compare August 25, 2026 10:27
@lacatoire lacatoire changed the title Fix privacy_protocol description in snmp3_real_walk Fix the SNMPv3 security protocol descriptions Aug 25, 2026
@lacatoire
lacatoire force-pushed the fix/issue-3690-snmp3-privacy-protocol branch from bbfaf72 to fbf7774 Compare August 25, 2026 10:46
@lacatoire lacatoire changed the title Fix the SNMPv3 security protocol descriptions Fix and factor out the SNMPv3 security parameter descriptions Aug 25, 2026
@lacatoire
lacatoire force-pushed the fix/issue-3690-snmp3-privacy-protocol branch from fbf7774 to b4ae554 Compare August 25, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Privacy protocol" gives authentication protocol options

1 participant