Skip to content

block_core_breadcrumbs_create_item: add cond. return type #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szepeviktor merged 1 commit into from
Aug 24, 2026
Merged

block_core_breadcrumbs_create_item: add cond. return type #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions functionMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
'apply_filters_ref_array' => [null, 'hook_name' => 'non-empty-string'],
'apply_filters_deprecated' => [null, 'hook_name' => 'non-empty-string'],
'backslashit' => [null, '@phpstan-pure' => ''],
'block_core_breadcrumbs_create_item' => ['($is_paged is true ? array{label: T, url: string} : array{label: T})', '@phpstan-template T' => 'of string', 'text' => 'T'],
'block_core_home_link_build_css_colors' => ['array{css_classes: list<string>, inline_styles: string}'],
'block_core_home_link_build_css_font_sizes' => ['array{css_classes: list<string>, inline_styles: string}'],
'block_core_navigation_build_css_colors' => ['array{css_classes: list<string>, inline_styles: string, overlay_css_classes: list<string>, overlay_inline_styles: string}'],
Expand Down
6 changes: 6 additions & 0 deletions tests/data/return/block-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,9 @@
assertType('array{css_classes: list<string>, inline_styles: string}', block_core_navigation_submenu_build_css_font_sizes(Faker::array()));
assertType('array{css_classes: list<string>, inline_styles: string, overlay_css_classes: list<string>, overlay_inline_styles: string}', block_core_page_list_build_css_colors(Faker::array(), Faker::array()));
assertType('array{css_classes: list<string>, inline_styles: string}', block_core_page_list_build_css_font_sizes(Faker::array()));

// Breadcrumbs
assertType('array{label: string, url?: string}', block_core_breadcrumbs_create_item(Faker::string(), Faker::bool()));
assertType("array{label: 'foo', url?: string}", block_core_breadcrumbs_create_item('foo', Faker::bool()));
assertType('array{label: string}', block_core_breadcrumbs_create_item(Faker::string(), false));
assertType('array{label: string, url: string}', block_core_breadcrumbs_create_item(Faker::string(), true));
3 changes: 3 additions & 0 deletions wordpress-stubs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113436,6 +113436,9 @@ function block_core_breadcrumbs_create_page_number_item($query_var = 'paged')
* @param bool $is_paged Whether we're on a paginated view.
*
* @return array The breadcrumb item data.
* @phpstan-template T of string
* @phpstan-param T $text
* @phpstan-return ($is_paged is true ? array{label: T, url: string} : array{label: T})
*/
function block_core_breadcrumbs_create_item($text, $is_paged = \false)
{
Expand Down
Loading