fix: support final IconData - #63
Conversation
|
Independent verification of this PR, plus one finding that I think matters for whoever It works in a real appI pinned this branch ( That error was taking ~42 test files down with it — whole files failing to compile, not
The 10 remaining are unrelated pre-existing failures in that project. Duotone icons The secondary-codepoint map must stay explicitThe 9k-line
48 pairs break the pattern — e.g. (It also rules out deriving the secondary at runtime, which would be worse regardless: Two things worth documenting before merge1. final glyph = data is PhosphorDuotoneIconData // now `data is IconData` — always true
? PhosphorIcon(data, ...) // everything routes here
: Icon(data, ...); // dead codeOutput stays correct ( 2. Duotone secondaries are no longer individually tree-shakeable. The old design hung On the other open PRsFor triage, since there are three of these: #66 makes icons plain |
Summary
Verification